6129 Commits

Author SHA1 Message Date
Florens Wasserfall
faeb213ce1 Remove collinear points from polygons right after slicing the stl into polygons.
Triangulation of planar surfaces results in additional edges (i.e. splitting a rectangle into two triangles).
Those edges end up as collinear points in the contour polygons and cause additional, redundant
computation. Most collinear points would be removed by Douglas-Peucker during gcode export.

Fixes #4726.
2019-02-09 20:56:34 -06:00
Mathieu Arnold
66b00c90c3 Fix typo. 2019-01-25 17:34:20 -06:00
Joseph Lenox
a4a0d52ccc min_layer_height and max_layer_height are arrays (because they are tied to the extruder). 2019-01-14 21:19:44 -06:00
Joseph Lenox
916c30c3d0
Merge pull request #4700 from andy5995/fix_typo_README
README.md:fix typo under directory structure section
2019-01-13 12:34:27 -06:00
andy5995
d0daa8d5ac
README.md:fix typo under directory structure section
[skip ci]
2019-01-13 11:08:56 -06:00
Joseph Lenox
3b338e5f84
Merge pull request #4691 from supermerill/brim_ears
brim ears
2019-01-10 20:31:40 -06:00
Joseph Lenox
c15c4fdcf6
Update PrintConfig.cpp 2019-01-10 20:28:41 -06:00
Joseph Lenox
cb9996a14b
Wordsmithing brim_ears 2019-01-10 20:26:52 -06:00
supermerill
32b0adacd9 add some little tests to brim ears 2019-01-10 23:07:06 +01:00
supermerill
c07a7fd2fc brim ears
- add brim_ears setting: bool: set to true to activate this new funtino
 - add brim_ears_max_angle : float : max angle for a corner to be assigned a brim ear.
2019-01-10 19:42:44 +01:00
andy5995
203f7927fe README.md:grammar improvement suggestions 2019-01-09 09:01:12 -06:00
Joseph Lenox
364f2a6e8c
Patch for #4620 - ensure posDetectSurfaces is invalidated on slice change (#4679)
* Update some language used 

* Completely check pre-condition in test. 

Make sure that we have 1 solid bottom layer and 2 solid top layers before invoking our change.

* Use step_invalidate() instead to ensure dependencies are invalidated as well.

Move set_started() until after invalidations.
2019-01-06 18:03:24 -06:00
Joseph Lenox
dabb5f3823 Fix skirt/Brim (#4669)
* Start implementing skirt/brim tests.

* Move skirt_height_z (representing the highest skirt height in actual Z coordinates) to Print and prime it with make_brim so it can be used in PrintGCode.

Updated test to correctly verify skirt is generated for one and multiple objects.

* Fallout from the config refactor; use correct accessors.

* Fix bug where brim was not generated (inverted logic)

* Finish porting tests, left one intentional failure as support material is not generated yet (segfaults).
2019-01-06 23:58:08 +01:00
Joseph Lenox
b3cac9d0fb
Cleanup old branch builds (#4680)
* #4620

Invalidate posDetectSurfaces during make_perimeters() when posSlice would also get invalidated.
Can't use invalidate_step() as that invalidates the perimeters as well.

* Add a test step to check for regression #4620 - behavior on running Print::process() again on the same model.

* Fix naming scheme for macos/osx builds to make it obvious if it is a PR or not.

* Remove previous versions of the same kind of branch or PR ID

* Adjust copied statements to account for different calling conventions; osx does not have an arch name argument for make_dmg

* Remember to set the version too

* Update windows build server command to clean up old branch builds.

* Specifically look for PR${PR_ID} instead of just ${PR_ID} to avoid unintentional deletions.

* don't symlink pull requests

* Update to call more functions on osx

* Only delete/clean once, not once per file uploaded.
2019-01-06 13:53:41 -06:00
Joseph Lenox
748dd3c23a add const begin/end iterators to SurfaceCollection to let it work in range-based for loops (const) 2019-01-05 23:45:17 -06:00
Joseph Lenox
f18c34006c Don't load swrast_dri.so, it's breaking(?) some driver/distro combinations and
may not actually help.
2019-01-05 19:25:25 -06:00
Joseph Lenox
b84be0deb5
Fix division by zero when min=max layer heights (#4672)
* #4670 Avoid a division by 0 crash if max_layer_height == min_layer_height (use scaling of 1.0).

* #4670 Limits -> Layer Height Limits

* Add config validation to Config.pm for adaptive slicing

* Also cover min_layer_height >= max_layer_height

* Correct logic for min/max layer height.
2019-01-05 18:45:59 -06:00
Joseph Lenox
39b157b4f8 Fallout from the config refactor; use correct accessors. 2019-01-02 23:51:46 -06:00
Joseph Lenox
45353b78c8 Remove trailing spaces in lines. 2019-01-01 22:30:29 -06:00
Joseph Lenox
ab38cca082 Clipper uses constexpr, it should conform to at least C++11. Fixes a build error on osx 2019-01-01 20:32:05 -06:00
Joseph Lenox
190de64396
Permit coBool options to be set with booleans; added an additional type enforcement for setting it with a string (only accepts "1" and "0"). (#4668) 2019-01-01 19:42:26 -06:00
Joseph Lenox
90f108ae8e
Use GCC8 instead of 4.9 for travis (#4666)
* Use GCC8 toolchain

* Allow appimage to preload included libgcc_s and stdc++ if necessary.

* Need to add header for boost::noncopyable

* use const strings for exceptions.

* use right header dir for shim

* Only use swrast_dri from appimage if it's old or doesn't exist.

* added note about where the apprun script was source from, thanks @darealshinji
2019-01-01 16:00:39 -06:00
Joseph Lenox
8e5a9cba71 #4654 Add a check for a 0 from the math to calculate the spacing; added a regression test to ensure that the spacing can't be 0 with otherwise valid inputs. 2018-12-31 10:49:30 -06:00
Joseph Lenox
f19fc3b6dc #4635 only use WXDIR if it is set. 2018-12-30 20:33:14 -06:00
Joseph Lenox
ed1560b4c7 #4635 Don't set WXDIR for perl builds (it isn't for that) 2018-12-30 20:33:14 -06:00
Joseph Lenox
9c3d9ca4a5 #4635 Correct assumptions about where the working folder is. 2018-12-30 20:33:14 -06:00
Joseph Lenox
6397d58c7d #4635 Use readlink -f instead of readlink for startup script on Linux. 2018-12-30 20:33:14 -06:00
Joseph Lenox
f0a21833f7 #4635 use SLIC3R_DIR during get_version 2018-12-30 20:33:14 -06:00
Joseph Lenox
f1fc6d24e4 #4635 Fix paths for cleanup routine; $archivefolder is an absolute path, not relative. 2018-12-30 20:33:14 -06:00
Joseph Lenox
4745d03bd8 #4635 Use correct expansion mechanism to test if var is set/unset for pp/perl 2018-12-30 20:33:14 -06:00
Joseph Lenox
9c7394db81 #4635 Clean up code branch 2018-12-30 20:33:14 -06:00
Joseph Lenox
a3073afcc2 #4635 Fix invocation for make_archive. 2018-12-30 20:33:14 -06:00
Joseph Lenox
ed45c01420 #4635 Move source dir determinator into common utilties. 2018-12-30 20:33:14 -06:00
Joseph Lenox
63c7d68140 #4635 Extra information about what gets copied where. 2018-12-30 20:33:14 -06:00
Joseph Lenox
53aac950b2 #4635 Remove end-of-line spaces. 2018-12-30 20:33:14 -06:00
Joseph Lenox
95a00456cf #4635 Be more verbose about what is getting copied where. 2018-12-30 20:33:14 -06:00
Joseph Lenox
0b84d55f23 #4635 Add usage note for make_archive 2018-12-30 20:33:14 -06:00
Joseph Lenox
9b5238ef91 #4635 Add some more useful diagnostic messages to make_archive.sh and fix a syntax error. 2018-12-30 20:33:14 -06:00
Joseph Lenox
a61d2a7c66 #4660 fix syntax error with a missing space in a ] 2018-12-30 18:11:23 -06:00
Joseph Lenox
3fa8924642 #4660 add coreutils to build-cpp as well 2018-12-30 18:11:23 -06:00
Joseph Lenox
a3e4998f03 #4660 homebrew package is coreutils 2018-12-30 18:11:23 -06:00
Joseph Lenox
3106a5e365 #4660 use greadlink from homebrew on osx for deployment 2018-12-30 18:11:23 -06:00
Joseph Lenox
3680e6a869
Update bug_report.md 2018-12-30 10:58:21 -06:00
Joseph Lenox
c960450a9d
Update feature_request.md
Refer directly to https://github.com/Prusa3D/Slic3r/issues
2018-12-30 10:57:53 -06:00
Joseph Lenox
55d6543124
Update bug_report.md
Make "DO NOT REPORT PRUSA3D BUGS HERE" more obvious.
2018-12-30 10:55:50 -06:00
Miro Hrončok
dc0f491602 Run on X11, as Wayland crashes Slic3r
See https://bugzilla.redhat.com/show_bug.cgi?id=1661324
and https://trac.wxwidgets.org/ticket/17702
2018-12-29 23:53:39 -06:00
Joseph Lenox
8f51287c27 Silence warnings for external libraries. 2018-12-29 23:50:31 -06:00
Joseph Lenox
518a72aa69 #4621 Applying changes as proposed by review. 2018-12-29 23:49:08 -06:00
Joseph Lenox
dd38214884 Apply suggestions from code review
Co-Authored-By: alranel <aar@cpan.org>
2018-12-29 23:49:08 -06:00
Alessandro Ranellucci
79d0677db2 Refactoring: make Slic3r::Config a thin wrapper around Slic3r::DynamicPrintConfig by moving its accessors to Slic3r::ConfigBase 2018-12-29 23:49:08 -06:00