quick bugfix in QR::isFullRank() (not 100% sure about the reference value

for the comparison to 0)
This commit is contained in:
Gael Guennebaud 2009-01-20 10:37:39 +00:00
parent 8690ba923c
commit 3e5b3a33fa

View File

@ -57,7 +57,7 @@ template<typename MatrixType> class QR
}
/** \returns whether or not the matrix is of full rank */
bool isFullRank() const { return ei_isMuchSmallerThan(m_hCoeffs.cwise().abs().minCoeff(), Scalar(1)); }
bool isFullRank() const { return !ei_isMuchSmallerThan(m_qr.diagonal().cwise().abs().minCoeff(), Scalar(1)); }
/** \returns a read-only expression of the matrix R of the actual the QR decomposition */
const Part<NestByValue<MatrixRBlockType>, UpperTriangular>