GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-04-29 15:24:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

BDCSVD fix -Wmaybe-uninitialized

Browse Source
This commit is contained in:
Charles Schlosser 2024-07-30 22:53:06 +00:00
parent 6331da95eb
commit 3f06651fd6
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Eigen/src/SVD/BDCSVD.h
View File

@ -52,9 +52,8 @@ struct traits<BDCSVD<MatrixType_, Options> > : svd_traits<MatrixType_, Options>
template <typename MatrixType, int Options> template <typename MatrixType, int Options>
struct allocate_small_svd { struct allocate_small_svd {
static void run(JacobiSVD<MatrixType, Options>& smallSvd, Index rows, Index cols, unsigned int computationOptions) { static void run(JacobiSVD<MatrixType, Options>& smallSvd, Index rows, Index cols, unsigned int) {
(void)computationOptions; internal::construct_at(&smallSvd, rows, cols);
smallSvd = JacobiSVD<MatrixType, Options>(rows, cols);
} }
}; };
@ -64,7 +63,7 @@ EIGEN_DISABLE_DEPRECATED_WARNING
template <typename MatrixType> template <typename MatrixType>
struct allocate_small_svd<MatrixType, 0> { struct allocate_small_svd<MatrixType, 0> {
static void run(JacobiSVD<MatrixType>& smallSvd, Index rows, Index cols, unsigned int computationOptions) { static void run(JacobiSVD<MatrixType>& smallSvd, Index rows, Index cols, unsigned int computationOptions) {
smallSvd = JacobiSVD<MatrixType>(rows, cols, computationOptions); internal::construct_at(&smallSvd, rows, cols, computationOptions);
} }
}; };

3
Eigen/src/SVD/JacobiSVD.h
View File

@ -553,7 +553,8 @@ class JacobiSVD : public SVDBase<JacobiSVD<MatrixType_, Options_> > {
* \deprecated Will be removed in the next major Eigen version. Options should * \deprecated Will be removed in the next major Eigen version. Options should
* be specified in the \a Options template parameter. * be specified in the \a Options template parameter.
*/ */
EIGEN_DEPRECATED JacobiSVD(Index rows, Index cols, unsigned int computationOptions) { // EIGEN_DEPRECATED // this constructor is used to allocate memory in BDCSVD
JacobiSVD(Index rows, Index cols, unsigned int computationOptions) {
internal::check_svd_options_assertions<MatrixType, Options>(computationOptions, rows, cols); internal::check_svd_options_assertions<MatrixType, Options>(computationOptions, rows, cols);
allocate(rows, cols, computationOptions); allocate(rows, cols, computationOptions);
} }