GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-13 02:08:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: handle error before using task (#6055)

Browse Source
This commit is contained in:
Srikanth Chekuri 2024-09-24 10:56:49 +05:30 committed by GitHub
parent 419d2da363
commit b49ed913c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/query-service/rules/manager.go
View File

@ -476,15 +476,15 @@ func (m *Manager) addTask(rule *PostableRule, taskName string) error {
UseLogsNewSchema: m.opts.UseLogsNewSchema, UseLogsNewSchema: m.opts.UseLogsNewSchema,
}) })
for _, r := range newTask.Rules() {
m.rules[r.ID()] = r
}
if err != nil { if err != nil {
zap.L().Error("creating rule task failed", zap.String("name", taskName), zap.Error(err)) zap.L().Error("creating rule task failed", zap.String("name", taskName), zap.Error(err))
return errors.New("error loading rules, previous rule set restored") return errors.New("error loading rules, previous rule set restored")
} }
for _, r := range newTask.Rules() {
m.rules[r.ID()] = r
}
// If there is an another task with the same identifier, raise an error // If there is an another task with the same identifier, raise an error
_, ok := m.tasks[taskName] _, ok := m.tasks[taskName]
if ok { if ok {