fix: promql alert expr formatting for composite queries with join/unless (#3784)

Co-authored-by: Ankit Nayan <ankit@signoz.io>
This commit is contained in:
Srikanth Chekuri 2023-10-25 20:42:18 +05:30 committed by GitHub
parent 2c2775c766
commit c55be0e392
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -309,7 +309,7 @@ func (r *PromRule) getPqlQuery() (string, error) {
if r.ruleCondition.Target != nil && r.ruleCondition.CompareOp != CompareOpNone {
unitConverter := converter.FromUnit(converter.Unit(r.ruleCondition.TargetUnit))
value := unitConverter.Convert(converter.Value{F: *r.ruleCondition.Target, U: converter.Unit(r.ruleCondition.TargetUnit)}, converter.Unit(r.Unit()))
query = fmt.Sprintf("%s %s %f", query, ResolveCompareOp(r.ruleCondition.CompareOp), value.F)
query = fmt.Sprintf("(%s) %s %f", query, ResolveCompareOp(r.ruleCondition.CompareOp), value.F)
return query, nil
} else {
return query, nil