GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-15 01:05:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove p99_latency references from funnel metrics

Browse Source
This commit is contained in:
ahmadshaheer 2025-06-02 09:15:20 +04:30 committed by Shivanshu Raj Shrivastava
parent 988495b612
commit d62b1cf49f
No known key found for this signature in database
GPG Key ID: D34D26C62AC3E9AE
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/api/traceFunnels/index.ts
View File

@ -196,8 +196,6 @@ export interface FunnelOverviewResponse {
avg_rate: number; avg_rate: number;
conversion_rate: number | null; conversion_rate: number | null;
errors: number; errors: number;
// TODO(shaheer): remove p99_latency once we have support for latency
p99_latency: number;
latency: number; latency: number;
}; };
}>; }>;

9
frontend/src/hooks/TracesFunnels/useFunnelMetrics.ts
View File

@ -49,11 +49,7 @@ export function useFunnelMetrics({
}, },
{ {
title: `P99 Latency`, title: `P99 Latency`,
value: getYAxisFormattedValue( value: getYAxisFormattedValue(sourceData.latency.toString(), 'ms'),
// TODO(shaheer): remove p99_latency once we have support for latency
(sourceData.latency ?? sourceData.p99_latency).toString(),
'ms',
),
}, },
]; ];
}, [overviewData?.payload?.data]); }, [overviewData?.payload?.data]);
@ -119,8 +115,7 @@ export function useFunnelStepsMetrics({
{ {
title: `${latencyType?.toUpperCase()} Latency`, title: `${latencyType?.toUpperCase()} Latency`,
value: getYAxisFormattedValue( value: getYAxisFormattedValue(
// TODO(shaheer): remove p99_latency once we have support for latency (sourceData.latency * 1_000_000).toString(),
((sourceData.latency ?? sourceData.p99_latency) * 1_000_000).toString(),
'ns', 'ns',
), ),
}, },