GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-13 19:25:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: edit widget is allowed for admin and editor (#1074)

Browse Source
This commit is contained in:
palash-signoz 2022-05-04 19:16:30 +05:30 committed by GitHub
parent c23f97c3d0
commit ffae767fab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
frontend/src/container/GridGraphLayout/WidgetHeader/index.tsx
View File

@ -65,7 +65,10 @@ function WidgetHeader({
}; };
const { role } = useSelector<AppState, AppReducer>((state) => state.app); const { role } = useSelector<AppState, AppReducer>((state) => state.app);
const [deleteWidget] = useComponentPermission(['delete_widget'], role); const [deleteWidget, editWidget] = useComponentPermission(
['delete_widget', 'edit_widget'],
role,
);
const menu = ( const menu = (
<Menu onClick={onMenuItemSelectHandler}> <Menu onClick={onMenuItemSelectHandler}>
@ -74,11 +77,14 @@ function WidgetHeader({
<span>View</span> <FullscreenOutlined /> <span>View</span> <FullscreenOutlined />
</MenuItemContainer> </MenuItemContainer>
</Menu.Item> </Menu.Item>
<Menu.Item key={keyMethodMapping.edit.key}>
<MenuItemContainer> {editWidget && (
<span>Edit</span> <EditFilled /> <Menu.Item key={keyMethodMapping.edit.key}>
</MenuItemContainer> <MenuItemContainer>
</Menu.Item> <span>Edit</span> <EditFilled />
</MenuItemContainer>
</Menu.Item>
)}
{deleteWidget && ( {deleteWidget && (
<> <>

4
frontend/src/utils/permission/index.ts
View File

@ -13,7 +13,8 @@ export type ComponentTypes =
| 'action' | 'action'
| 'save_layout' | 'save_layout'
| 'edit_dashboard' | 'edit_dashboard'
| 'delete_widget'; | 'delete_widget'
| 'edit_widget';
export const componentPermission: Record<ComponentTypes, ROLES[]> = { export const componentPermission: Record<ComponentTypes, ROLES[]> = {
current_org_settings: ['ADMIN'], current_org_settings: ['ADMIN'],
@ -28,6 +29,7 @@ export const componentPermission: Record<ComponentTypes, ROLES[]> = {
save_layout: ['ADMIN', 'EDITOR'], save_layout: ['ADMIN', 'EDITOR'],
edit_dashboard: ['ADMIN', 'EDITOR'], edit_dashboard: ['ADMIN', 'EDITOR'],
delete_widget: ['ADMIN', 'EDITOR'], delete_widget: ['ADMIN', 'EDITOR'],
edit_widget: ['ADMIN', 'EDITOR'],
}; };
export const routePermission: Record<keyof typeof ROUTES, ROLES[]> = { export const routePermission: Record<keyof typeof ROUTES, ROLES[]> = {