It doesn't give a problem right now since we're only iterating over lists of length 1 here, but in the future this could cause weird bugs.
Contributes to issue CURA-2822.
Properties is a dictionary inside the metadata dictionary. If you change one of the properties, it'll check afterwards if the dictionary is different from what it was before, but since the dictionary is passed by reference all the time, it'll think that the dictionary didn't change: The reference is still the same, so the thing it checks against is updated along.
This solution is a bit ugly but it does notice when the metadata changed inside the properties and then emits a change signal.
Contributes to issue CURA-2822.
Previously we also called the ID 'Not Supported' but we decided against that for new profiles, since that would mean that if the profile ever becomes supported we'd have to do a rename of the user's file names in their settings via a version upgrade. So now the ID is as if it's supported but the user-visible name still says that it's Not Supported and the profile still becomes orange.
Contributes to issue CURA-3960.
These have not been tested or even opened yet at this point, but by the time I've pushed the commit they will be. This should fix the missing translation and inconsistent wording.
Contributes to issue CURA-3950.
These settings say the same, only the infill_overlap_mm one overwrites the infill_overlap setting. I therefore removed infill_overlap_mm so that the mm gets auto-calculated and none of the settings are overwritten any more (so they don't get greyed out).
Contributes to issue CURA-3960.
This was delivered false by the materials team. It seems that in the end they decided to not use gradual infill for PP but only made the change in UM3, not UM2+. Removing gradual infill also requires me to set the infill density to 20% (the default).
Contributes to issue CURA-3960.
And then also update the profiles to make the profiles end up at what it was originally (I confirmed this with the materials team).
Contributes to issue CURA-3960.
It was giving a warning for 0.8mm polypropylene because that was set to 0.5mm hop. It was decided that a minimum value at all for z-hop is nonsense because you can just disable z-hop without getting a warning. I'm still setting it to zero because negative will still go wrong in your print.
Contributes to issue CURA-3960.