372 Commits

Author SHA1 Message Date
Nino van Hooff
dd8993e88c revert 0 buildvolume edgedisallowedsize for one_at_a_time
Turns out that the artificial disallowed area around the inside of the
build volume was necessary to take the brim into account when deciding
whether a model was outside the buildvolume.
The issue for which I removed this in the first place seems not to be
an issue anymore due to other commits

Reverts and e5fb9fb8 and e5c9bca
CURA-6522
2019-12-06 12:17:21 +01:00
Jaime van Kessel
50d72692d8
Merge branch 'master' of github.com:Ultimaker/Cura into CURA-6522_one_at_a_time_overlapping_build_area 2019-11-20 16:48:00 +01:00
Jaime van Kessel
00078fd659
Remove a bunch of unused imports 2019-11-08 13:38:42 +01:00
Nino van Hooff
e5fb9fb8cf Remove hack used to draw some build area edge border
This disallowed area should not exist and caused difference in behavior
between all-at-once and one-at-a-time printing for a single object

CURA-6522
2019-10-31 14:59:54 +01:00
Ghostkeeper
ce4c5a1c93
Remove unnecessary listening to switching extruder tabs
Also fix unnecessary emitting of switching extruder tabs.

This should improve performance a lot. I tested a lot of things and am convinced that it didn't break anything. But the automated GUI tests and QA team should be the final arbiters of that...

Contributes to issue CURA-6793.
2019-10-15 15:01:45 +02:00
Jaime van Kessel
241ca56e6e
Fix stupid derp issue
I really need coffee before coding
2019-09-26 09:46:02 +02:00
Jaime van Kessel
dbbeeef9a5
Don't render buildvolume if it's set to invisible 2019-09-26 09:11:54 +02:00
Jaime van Kessel
0f8dfeafc1
fix typo 2019-09-16 09:26:12 +02:00
Jaime van Kessel
0ff9d72c4c
Remove use of deprecated extruders property 2019-09-13 17:27:16 +02:00
Jaime van Kessel
0cfaac3940 Set the BuildVolume node to disabled
This prevents accidental modification of the node
2019-08-29 11:23:01 +02:00
Lipu Fei
bb34e0da39 Increase axis line width 2019-08-05 10:44:43 +02:00
Jaime van Kessel
9ceb9ce18b Fix typing issues
They were caused by upgrading to a higher mypy version, which found more mistakes
2019-07-23 12:58:46 +02:00
Jaime van Kessel
6bb9e6097a Rename "collideWithArea" to "collideWithAreas"
This better reflects what it does (eg; it is checking for multiple colissions, not just one)
2019-07-19 16:23:57 +02:00
Remco Burema
f5b0cae554 Prime-brim calculation needs adhesion extruder, not just any. 2019-07-02 07:46:21 +02:00
Jaime van Kessel
6136f5a2f2 Further simplify the build volume code 2019-06-28 15:22:58 +02:00
Jaime van Kessel
691d106719 Remove old unused code 2019-06-28 15:09:08 +02:00
Jaime van Kessel
2133fc78e0 Remove unused code 2019-06-28 15:01:09 +02:00
Jaime van Kessel
efc6ef2905 Add missing typing 2019-06-28 13:44:47 +02:00
Lipu Fei
1d85e60a6b Merge remote-tracking branch 'origin/master' into CURA-6460_remove_square_tower 2019-06-17 13:11:07 +02:00
Jaime van Kessel
f842769c1d Fix situation where _calculateMoveFromWallRadius could cause exception 2019-06-07 17:21:28 +02:00
Jaime van Kessel
4018c24b4c Split out all the individual steps for getting the edgeDisallowedSize
This makes it so much easier to write tests for it
2019-06-07 17:14:51 +02:00
Jaime van Kessel
3967c995f1 Split out updating the machine size properties so it can be tested easily 2019-06-07 16:42:51 +02:00
Jaime van Kessel
2f83fa1a42 Small code simplification 2019-06-07 16:34:38 +02:00
Jaime van Kessel
887f50dee4 Add tests for calculating the extra z clearance 2019-06-07 16:30:29 +02:00
Jaime van Kessel
54740dd486 Add some unhappy flow tests for rebuild 2019-06-07 16:09:18 +02:00
Jaime van Kessel
090b7ac225 Refactor the rebuild function to cut it up in smaller bits 2019-06-07 16:08:47 +02:00
Jaime van Kessel
06aaf40d06 Add test for computation of prime blob 2019-06-07 14:29:15 +02:00
Jaime van Kessel
1759e01b27 Make _geSettingFromAllExtruders use zip
This is a bit cleaner to use
2019-06-07 13:40:41 +02:00
Jaime van Kessel
a6ca49d68c Fix typing for Buildvolume 2019-06-07 13:34:57 +02:00
Remco Burema
a30814fe52 Remove square prime tower. [CURA-6460] 2019-06-06 10:07:05 +02:00
Jaime van Kessel
6e053e0bb6 Mark objects that are completely below the buildplate as outside of the buildvolume
CURA-6545
2019-06-05 13:25:43 +02:00
Jaime van Kessel
55c7f546b2 Split up the rebuild function of the buildvolume
This should make it a lot easier to test
2019-05-31 17:32:49 +02:00
Jaime van Kessel
f85095f5d8 Added simple test for BuildVolume 2019-05-31 17:19:27 +02:00
Ghostkeeper
ac9f892e09
Remove useless '== True' 2019-05-31 12:53:08 +02:00
Ghostkeeper
72d1f39112
Document better what adhesion spacing is used
Contributes to issue CURA-6551.
2019-05-31 12:48:18 +02:00
Remco Burema
dc1679bbdd Fix: adhesion could overlap model because order of (el)if statements. 2019-05-29 13:12:34 +02:00
Ghostkeeper
650204dae7
Merge branch '4.0' 2019-02-21 09:09:19 +01:00
Jaime van Kessel
3f18b0b974 Increase agressiveness of short circuit logic; Just check if the node is slicable
That should also filter out platform, buildVolume and convexHulLNodes
2019-02-19 18:00:20 +01:00
Jaime van Kessel
22b70e1a34 Ignore sceneChange signals if the camera triggered them in some places
These places weren't interested in all changes. They can probably be more
strict, but the camera is a really safe bet (and already greatly decreases
the number of updates, especially when just moving the camera)
2019-02-19 17:06:48 +01:00
Remco Burema
2f5e973836 Partly revert sugested changes for '()'s because line-breaks. [CURA-5864] 2019-02-14 15:01:32 +01:00
Jaime van Kessel
68cec2679c
Apply suggestions from code review.
Cross some brackets and dot some quotes.
[CURA-5864]

Co-Authored-By: rburema <41987080+rburema@users.noreply.github.com>
2019-02-14 14:52:42 +01:00
Remco Burema
a601e0878c Explicitly also check for Raft when checking for prime-tower=brim. [CURA-5864] 2019-02-13 15:46:39 +01:00
Remco Burema
0a860c7011 Dissalow overlap of skirt/brim (model vs. prime-towrer) in case of prime-tower brim. [CURA-5864] 2019-02-05 18:15:23 +01:00
Lipu Fei
173f125d3e Fix merge conflicts 2019-01-24 14:55:29 +01:00
Remco Burema
aae06fe0fa Prevent calculations with brim width larger than build-plate. [CURA-6094] 2019-01-21 17:47:13 +01:00
Remco Burema
f62e8b4bb2 Create 'brim for prime tower only' option (see also backend PR). [CURA-5864] 2018-12-21 17:38:30 +01:00
Jaime van Kessel
bb1950525a Limit the amount of times the buildplate rebuild is done
CURA-6016
2018-12-11 09:42:34 +01:00
Ghostkeeper
c44b74454f
Revert "No longer make BuildVolume set max bounds."
This reverts commit 1467e703ae121c3f2fa02ee7258bdeba63f80c5c.
This variable was actually used... In Uranium, by the scale tiny models feature.
2018-12-07 14:22:39 +01:00
fieldOfView
66c3cc9204 Prevent an error during start up 2018-11-14 14:20:42 +01:00
Aleksei S
436860f841 Don't show prime tower shadow if only one extruder is enabled
CURA-5740
2018-10-04 11:36:02 +02:00