25107 Commits

Author SHA1 Message Date
Kostas Karmas
189d00c3ed Fix toolbox not initializing due to enabledChanged signal
The Connections in qml is a QObject and it has an enabledChanged signal by default.
Therefore, we cannot really use the Connections to connect to the enabledChanged signal of e.g.
a python class, because qml complains that there is already a function named enabledChanged() in
the Connections.

To circumvent that, we can simply rename the enabledChanged() signal of the Toolbox to
toolboxEnabledChanged().
2021-03-30 09:02:56 +02:00
Kostas Karmas
7827b36ab7 Fix QML warnings due to depricated on<signal> calls in Connections
As of 5.12, the signals used in connections should not be declared as on<signal>, but as
function on<signal>(arguments).
2021-03-30 09:02:48 +02:00
Jelle Spijker
a277adae64
Merge pull request #9462 from Ultimaker/CURA-7813_fix_crash_globalstack
Workaround: Before closing the window, remove the global stack
2021-03-29 16:16:17 +02:00
Jaime van Kessel
8b447ca5cd
Merge pull request #9270 from mehmetsutas/Rigid3D
Update Rigid3D definitions / Add Mucit2 definition
2021-03-29 13:53:30 +02:00
Ghostkeeper
4eec099c31
Slightly lower build plate mesh
The top of the build plate mesh seems to be 1mm into the build volume in its actual coordinates. The mesh was lowered by 0.8mm. Probably they tried to lower it by 1mm first and then found that it was z-fighting. I'm resolving the z-fight the other way around so that the mesh actually appears completely below the build volume. This makes the build plate grid more clear. No more grey film on top of it.
2021-03-29 13:46:58 +02:00
Ghostkeeper
309bd52eb4
Merge branch 'defs_inat' of https://github.com/MarkINAT/Cura into MarkINAT-defs_inat 2021-03-29 13:40:10 +02:00
Jelle Spijker
c798c7b99e
Merge remote-tracking branch 'origin/master' into CURA-7813_fix_crash_globalstack 2021-03-29 10:17:31 +02:00
MarkMan0
d7c8d05be9 Change machine_start_gcode 2021-03-26 14:58:26 +01:00
MarkMan0
cc76002c03 disable infill_before_walls 2021-03-26 11:49:47 +01:00
MarkMan0
5872065dc8 fix temperatures 2021-03-26 11:49:35 +01:00
Remco Burema
729d3afd32
Workaround discinction model/models/group.
Fixes #9448
2021-03-26 11:26:03 +01:00
MarkMan0
ad803c22fd Fix printer height 2021-03-26 11:20:03 +01:00
Jaime van Kessel
2e88a3463c
Merge branch 'CURA-8014_welcome_pages_attract_mode' of github.com:Ultimaker/Cura 2021-03-25 15:53:59 +01:00
Jaime van Kessel
4e80ac5138
Use alignment instead of anchors
Since it's within a layout, you can't use anchors

CURA-8014
2021-03-25 15:53:08 +01:00
Remco Burema
839ac63241
Darker inactive dots in Whats New.
CURA-8014
2021-03-25 15:35:53 +01:00
Kostas Karmas
179d77ef5c Transfer the "What's new" and "Changelog" pages at the end of wizard
To match the requirements specified in the ticket.

CURA-8014
2021-03-25 13:29:17 +01:00
Jaime van Kessel
ab95af167c
Merge branch 'CURA-8094_onoarding_flow' of github.com:Ultimaker/Cura 2021-03-25 13:12:44 +01:00
Kostas Karmas
7af6ea5cc5 Remove unnecessary horizontalCenter anchor
Left and right anchors can't work at the same time with the horizontalCenter. In this case it
makes more sence to remove the horizontalCenter, since the left and right ones also define the
width of the rectangle.

CURA-8014
2021-03-25 12:51:07 +01:00
Kostas Karmas
55cb7f88a7 Change bottom left button text to "Skip"
Or else the page shows two buttons "Next" buttons.

CURA-8014
2021-03-25 12:47:07 +01:00
Jaime van Kessel
46c4a70b50
Merge branch 'CURA-8066_Change_tableView_colors' of github.com:Ultimaker/Cura 2021-03-25 11:33:54 +01:00
pnt103
2ed40fe2c6
Get last position from previous layer instead.
Old code was next-next layer, which is actually the layer _after_ the one that is meant.

Fixes #9430
CURA-8116
2021-03-25 09:19:45 +01:00
Kostas Karmas
e55e157925 Change label text to not contain a new line character
CURA-8094
2021-03-25 09:05:49 +01:00
Kostas Karmas
18c0510727 Fix review comments in WelcomeContent.qml
CURA-8094
2021-03-25 09:00:14 +01:00
Kostas Karmas
d6c1ffdda3 Fix review comments in CloudContent.qml
CURA-8094
2021-03-25 08:58:37 +01:00
Kostas Karmas
0488887780 Add image sizes for welcome dialog
CURA-8094
2021-03-25 08:57:15 +01:00
Kostas Karmas
c38b6f0522 Change SVG icon names
CURA-8094
2021-03-25 08:56:15 +01:00
Kostas Karmas
b21a21c0f2 Add missing style
Without it the svgs are rendered as completely black.

CURA-8094
2021-03-24 16:47:40 +01:00
Remco Burema
7304226aca
Increase reliance on anchors instead of width-height.
CURA-8014
2021-03-24 16:44:58 +01:00
Remco Burema
f1cbe1a958
... and fix typing as a result of the last commit.
CURA-8014
2021-03-24 16:29:38 +01:00
Remco Burema
f95c09db37
Type-checks, not just type comments, and static- over class-method.
CURA-8014
2021-03-24 16:18:56 +01:00
Remco Burema
98ed2bc8b6
Adopt code-review remark.
Use height instead of implicit height.

Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2021-03-24 15:59:22 +01:00
Remco Burema
d033e066f7
Adopt code-review remark.
Use width instead of implicit width.

Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2021-03-24 15:58:44 +01:00
Remco Burema
b04bbfdee2
Adopt code-review remark.
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2021-03-24 15:57:41 +01:00
Remco Burema
5083db8d44
On new install or update, have highlights not just changelog.
Place images in resources/images/whats_new/N.format and texts in resources/texts/whats_new/N.format where N is the ordinal and format the respective allowed formats.

CURA-8014
2021-03-24 12:00:05 +01:00
Ghostkeeper
91fe9e8ebf
Merge branch 'patch-1' of https://github.com/EGOiST1991/Cura into EGOiST1991-patch-1 2021-03-23 13:57:00 +01:00
Jelle Spijker
1b8d261e95
Correct spacing in Welcome screen
CURA-8094 Cura onboarding flow
2021-03-23 12:57:38 +01:00
Jelle Spijker
778db451ad
fixed typo
CURA-8094 Cura onboarding flow
2021-03-23 11:40:23 +01:00
Jelle Spijker
91c71e1c8a
Added missing 48px icons
These are the new icons. Specifically for 48px.

CURA-8094 Cura onboarding flow
2021-03-23 11:22:20 +01:00
Jelle Spijker
c727fe5e0c
Updated Sign in screen first run
CURA-8094 Cura onboarding flow
2021-03-23 11:20:38 +01:00
Jelle Spijker
ccf18a7443
Updated Welcome screen first run
CURA-8094 Cura onboarding flow
2021-03-23 11:18:25 +01:00
Ghostkeeper
93a3f15b4f
Workaround: Before closing the window, remove the global stack
There's an extensive explanation in the documentation. But truth be told, I don't know why the conversion of global stack to QObject fails after the main window is closed. This may be something in PyQt as it doesn't seem to happen for Nallath who is still on PyQt5.11, but did update Qt to 5.14. So this should be considered a workaround.

This is currently just ONE of the reasons why the application crashes on exit in PyQt5.14+. There is another, much more mysterious issue that is causing the application to segfault on exit, which is still happening. But if it didn't happen it would otherwise still crash on this, so this needs to be solved anyway.

Contributes to issue CURA-7813.
2021-03-22 15:55:37 +01:00
Ghostkeeper
2c33ebdd05
Document part of the vertex positions generated here
Encountered as I made a failed attempt at solving the issue with rendering transparent support. I tried to order vertices appropriately but failed miserably.
2021-03-21 23:15:15 +01:00
Ghostkeeper
bcf180985d
Fix crash when adding USB device before global stack is created
Like when you plug in a 3D printer via USB while still in the welcome screen.

Fixes Sentry issue CURA-1ZR.
2021-03-18 16:17:09 +01:00
Ghostkeeper
1f9b4c3964
Handle deleting profiles better
When deleting profiles, the current item is set to null.
The Activate button was checking if the current profile was already active, and disabling the button if it was. But the button was still enabled if the current item is null because isCurrentItemActivated is only true if there is a current item. So to properly disable the button we need to check also if there is a current item.
The onItemsChanged signal can also trigger if the item that matches the toSelectItemName has no quality_changes_group, i.e. a built-in profile.

Probably fixes Sentry issue CURA-43.
2021-03-18 02:21:14 +01:00
Ghostkeeper
58369822fc
Clean up invalid quality changes robust to asynchronous changes
It's possible that a profile is no longer in the registry by the time it gets to that point in the list if this clean-up is triggered by the very action of deleting a profile.

Fixes Sentry issue CURA-1T5.
2021-03-16 16:36:01 +01:00
Ghostkeeper
f4b417883e
Merge branch 'patch-1' of https://github.com/TheTRCG/Cura into TheTRCG-patch-1 2021-03-15 17:47:49 +01:00
Kostas Karmas
547698cffc Change TableView row color and text color when the row is selected
CURA-8066
2021-03-12 17:30:17 +01:00
Ghostkeeper
87d3f6fd22
More consistent Initial Retracted Position setting
Contributes to issue CURA-8038.
2021-03-10 18:24:01 +01:00
Ghostkeeper
74ac7a4cea
Merge branch 'CURA-8148_extruders_switch_retraction_initialization' of https://github.com/sisu70/Cura into sisu70-CURA-8148_extruders_switch_retraction_initialization 2021-03-10 17:38:00 +01:00
Jelle Spijker
2e3d85b9d0
Merge pull request #9377 from Ultimaker/fix_layer_view_greyout_on_model_switch
Fix layer view being greyed out after reslicing gives same current layer
2021-03-10 07:49:24 +01:00